FilterOptions: replace new Event() with DOM.trigger() #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The event constructor does not work in ie11, but we have an ie11 compliant implementation with DOM.trigger() T=https://yextops.zendesk.com/agent/tickets/348126 TEST=manual Test that before, in browserstack ie11, clicking the X button in a searchable facet has console error With code change, no console error
tmeyer2115
reviewed
Sep 2, 2020
| 'bubbles': true, | ||
| 'cancelable': true | ||
| })); | ||
| DOM.trigger(searchInputEl, 'input'); |
There was a problem hiding this comment.
Do we need to include any of the event settings in the call to DOM.trigger? Or do the defaults in _customEvent get us what we need?
There was a problem hiding this comment.
yes the defaults are the same
tmeyer2115
approved these changes
Sep 2, 2020
oshi97
added a commit
that referenced
this pull request
Sep 2, 2020
The event constructor does not work in ie11, but we have an ie11 compliant implementation with DOM.trigger() T=https://yextops.zendesk.com/agent/tickets/348126 TEST=manual Test that before, in browserstack ie11, clicking the X button in a searchable facet has console error With code change, no console error and that it still clears the facet search input on chrome + ie11
|
Heya heads up, for some reason this PR didn't run |
Oh shoot, thanks Christian. I didn't realize our ci didn't run (looks like there were some organization changes? I can't open project settings anymore) |
oshi97
added a commit
that referenced
this pull request
Sep 3, 2020
The event constructor does not work in ie11, but we have an ie11 compliant implementation with DOM.trigger() T=https://yextops.zendesk.com/agent/tickets/348126 TEST=manual Test that before, in browserstack ie11, clicking the X button in a searchable facet has console error With code change, no console error and that it still clears the facet search input on chrome + ie11
oshi97
added a commit
that referenced
this pull request
Sep 4, 2020
The event constructor does not work in ie11, but we have an ie11 compliant implementation with DOM.trigger() T=https://yextops.zendesk.com/agent/tickets/348126 TEST=manual Test that before, in browserstack ie11, clicking the X button in a searchable facet has console error With code change, no console error and that it still clears the facet search input on chrome + ie11
oshi97
added a commit
that referenced
this pull request
Sep 9, 2020
The event constructor does not work in ie11, but we have an ie11 compliant implementation with DOM.trigger() T=https://yextops.zendesk.com/agent/tickets/348126 TEST=manual Test that before, in browserstack ie11, clicking the X button in a searchable facet has console error With code change, no console error and that it still clears the facet search input on chrome + ie11
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event constructor does not work in ie11, but we have an
ie11 compliant implementation with DOM.trigger()
T=https://yextops.zendesk.com/agent/tickets/348126
TEST=manual
Test that before, in browserstack ie11,
clicking the X button in a searchable facet has console error
With code change, no console error
and that it still clears the facet search input on chrome + ie11